Ubisoft OAuth integration #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bux42/tm-dojo/hswTALSAgqDCjsK4U98hrUcwHAwv |
davidbmaier
requested changes
Jul 28, 2021
| const sessions = db.collection('sessions'); | ||
| const sessionId = uuid(); | ||
| await sessions.insertOne({ | ||
| sessionId, |
There was a problem hiding this comment.
Not something we have to do right now, but I wonder if we should store the hash of the secret instead of the real session. Obviously that means we'd also have to change the validation when requests come in - let me know what you think.
davidbmaier
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Login with Ubisoft" button to authenticate the user.
⚠ Requires .env changes! ⚠
OAuth requires you to create an application on api.trackmania.com:
Client:
NEXT_PUBLIC_CLIENT_ID=<CLIENT_ID from api.trackmania.com>Server:
TM_API_CLIENT_ID=<CLIENT_ID from api.trackmania.com>TM_API_CLIENT_SECRET=<CLIENT_SECRET from api.trackmania.com>Flow Summary
api.trackmania.com/...authentication URL<domain>/auth_redirectcontaining a code and state in query params/authorizeendpoint{withCredentials: true}config in axios (will create an axios interface with this default in a later PR)New Endpoints
/authorizefor first authentication/logoutto logout. Removes session and sends back a sessionId cookie with an age of -1 (instantly deletes cookie)/meto fetch user information for the logged in user